Add open source resources for docs #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
besated
requested changes
Apr 17, 2024
| @@ -1,23 +1,48 @@ | |||
| # Nextra Docs Template | |||
| ## Quick Start | |||
| Ensure you have `yarn` installed (macOS users can Run `brew install yarn`) | |||
There was a problem hiding this comment.
the docs actually uses pnpm instead of yarn, can you update this?
also we'll need to update the github workflow above
There was a problem hiding this comment.
Oh! I've been using yarn the whole time
Just updated with instructions for pnpm
| For more information on how the docs are structured, please refer to the [Nextra docs](https://nextra.site/docs/guide). | ||
|
|
||
| ### Changing Content | ||
| All content submitted will be reviewed by a maintainer |
There was a problem hiding this comment.
can u make sure that each PR requires at least one maintainer to review
There was a problem hiding this comment.
Added a CODEOWNERS file to specify this, but will probably only take effect when it's merged into main
besated
approved these changes
Apr 18, 2024
mj850
added a commit
that referenced
this pull request
Apr 18, 2024
* style guide * workflow * test remove push * build * use pnpm instead * pnpm setup * version * add codeowners file * revert to yarn * edit link
mj850
added a commit
that referenced
this pull request
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update README and Styleguide to encourage open source contributions
Add Github workflow to gate merging on validation (just simply building)